Skip to content

Remove passthrough toggle from editor #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

Remove passthrough toggle from editor #16

merged 2 commits into from
Mar 10, 2025

Conversation

bparks13
Copy link
Member

@bparks13 bparks13 commented Feb 4, 2025

Passthrough is now determined by the headstage selection in the combo box.

@bparks13
Remove passthrough toggle from editor
6c43b80 
- Passthrough is now determined by the headstage combobox selection
@bparks13 bparks13 added this to the Neuropixels 1.0f milestone Feb 4, 2025
@bparks13 bparks13 self-assigned this Feb 4, 2025
@bparks13 bparks13 requested a review from jonnew March 4, 2025 18:47
jonnew
jonnew approved these changes Mar 7, 2025
View reviewed changes
Copy link

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During our meeting my comments were

Heastages connected through passthroughs dont tell you their device IDs, but you can see if they are locked or not. This is what bonsai does

@bparks13 bparks13 merged commit 488e1ef into main Mar 10, 2025
@bparks13 bparks13 deleted the issue-8 branch March 10, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnew jonnew jonnew approved these changes

Assignees

@bparks13 bparks13

Labels
None yet
Projects
None yet
Milestone
Neuropixels 1.0f and 2.0e
Development

Successfully merging this pull request may close these issues.

Remove passthrough toggle
2 participants
@bparks13 @jonnew